search

CrowdHailer / raxx

Interface for HTTP webservers, frameworks and clients
https://hexdocs.pm/raxx
Apache License 2.0
401 stars 29 forks source link

Handle case-insensitive "connection" header #121

Closed CharlesOkwuagwu closed 5 years ago

CrowdHailer commented 6 years ago

Tests aren't passing

CharlesOkwuagwu commented 6 years ago

I've fixed the issue with the pattern match that was failing

CrowdHailer commented 6 years ago

Thanks,

Can you add a test. also an entry to the changelog. Just start a new section at the top under master (in place of a release version)

CharlesOkwuagwu commented 6 years ago

This is a very minor change to the internal workings ... does it really warrant a change in the build number?

CrowdHailer commented 6 years ago

No necessarily but it will be part of the list of changes that makes up the next release.

Also I don't think there is any harm releasing even just this under a patch bump.

CharlesOkwuagwu commented 6 years ago

...also an entry to the changelog. Just start a new section at the top under master (in place of a release version)

Not sure how to word this change/fix/ update

CrowdHailer commented 6 years ago

Fixed

https://keepachangelog.com/en/1.0.0/

CrowdHailer commented 5 years ago

Handled by #122