CrowdHailer / raxx

Interface for HTTP webservers, frameworks and clients
https://hexdocs.pm/raxx
Apache License 2.0
400 stars 29 forks source link

Change Raxx.get/set_header calls to allow duplicate headers. #145

Closed varnerac closed 5 years ago

CrowdHailer commented 5 years ago

Needs some handling for cookie special case.

Might make more sense as a new function add_header because of the number of headers that exist that should only be added once. e.g. content-length content-type

varnerac commented 5 years ago

Given the number of corner cases, I'm starting to feel like this patch just isn't worth it. Thoughts?

CrowdHailer commented 5 years ago

Tempted to agree, shall we close this PR? Can always add it later.