search

CrowdHailer / raxx

Interface for HTTP webservers, frameworks and clients
https://hexdocs.pm/raxx
Apache License 2.0
402 stars 29 forks source link

Fail tests if any compiler warnings are present #57

Closed CrowdHailer closed 6 years ago

CrowdHailer commented 6 years ago

The test step should fail if any compiler warnings are emitted. This condition should be added to the travis setup so that PR's will fail with any new warnings.

There seams to be some discussion around a --warnings-as-errors option to mix compile but I could not make it work.

https://stackoverflow.com/questions/31982577/is-it-possible-to-get-the-compiler-to-exit-early-failing-the-build-if-a-compil

CrowdHailer commented 6 years ago

Just add elixirc_options to mix file https://github.com/elixir-lang/elixir/blob/master/lib/mix/lib/mix/tasks/compile.elixir.ex#L35-L39

CrowdHailer commented 6 years ago

Fixed with this compiler option https://github.com/CrowdHailer/raxx/commit/86dac23449a1ce90a6de8bf45a82faa2f56026d3