search

CrowdHailer / raxx

Interface for HTTP webservers, frameworks and clients
https://hexdocs.pm/raxx
Apache License 2.0
402 stars 29 forks source link

add middleware Raxx.Ribbon #87

Closed CrowdHailer closed 6 years ago

CrowdHailer commented 6 years ago

Clone of https://github.com/stnly/plug_ribbon

I think this could be a nice thing to have. It doen't need to be tied to showing env information.

use Raxx.Ribbon

defp ribbon(_config) do
  System.get_env("MIX_ENV")
end
matlc commented 6 years ago

I'm fairly new to Elixir, but this enhancement sounds doable. I'll give it a try.

Also, thanks for the clear issue labels and example usage within the issue. It's really helpful!

CrowdHailer commented 6 years ago

@cryic Go for it! This will require some macro understanding. Not wanting to put you off but a heads up if you are completely new to elixir.

matlc commented 6 years ago

@CrowdHailer Thanks for info. Yeah, I've been mainly reading about macros, so this will be my first time implementing. Might have some questions for you later.

CrowdHailer commented 6 years ago

@cryic How goes this? I am tempted to close this issue. It would be a nice feature to have but it's absence is not really an issue

matlc commented 6 years ago

@CrowdHailer It is going alright. Basically, life/work have picked up, so I've been spending much less time than I'd like on this.

I agree about it being a nice feature but not really an issue. Feel free to close this issue, and when I get something complete, I'll check-in with you. It could still be a independent pull request or maybe release it as a separate package.

Thanks for checking in!

CrowdHailer commented 6 years ago

:+1:

Good luck and hopefully here from you again