search

CrowdHailer / raxx_kit

Get started with Raxx + Elixir
http://crowdhailer.me/2018-05-01/building-a-distributed-chatroom-with-raxx-kit/
Apache License 2.0
122 stars 10 forks source link

[#99] Delete System.version & set elixir as ">= 1.7.4" #102

Closed davecaos closed 4 years ago

davecaos commented 4 years ago

Delete System.version from mix.exs template and set elixir as ">= 1.7.4" to match the fixed version at Dockerfile template. image

CrowdHailer commented 4 years ago

Can you add a bit more information on why this is the right thing to do.

davecaos commented 4 years ago

Sure! The last time I used raxx_kit to scaffold Ace server I had to change by hand the elixir version in the mix.exs and dockerfiles to 1.9.4, also I realized that there less version available at docker hub than I expected. Now I am not sure if this is the righ thing to do. At least set it to 1.7.4 or greater it tackle the problem in a simpler manner, but delegate responsibility to the raxx_kit's user to care about the mix configuration.

Another option could be a flag to set fixed version like --elixir_version x.x.x.

CrowdHailer commented 4 years ago

I think the thing to do is update the value in the dockerfile to the latest value. and leave the mix file to use the elixir version that generated it

davecaos commented 4 years ago

Ah OK! the System.version value is for set the elixir version that generated the server, not for only match the Elixir version that user it is using at the moment. I will update this PR with only changing the Elixir version to 1.10.2 in the Dockerfile

CrowdHailer commented 4 years ago

Thanks, btw I hadn't reread the issue #99 now I've remembered there are a bunch of caveats doing anything cleverer. This is a helpful bump on the docker file.

Can you add a changelog entry with todays date and I can push it as 12.2

davecaos commented 4 years ago

Thanks, btw I hadn't reread the issue #99 now I've remembered there are a bunch of caveats doing anything cleverer. This is a helpful bump on the docker file.

Can you add a changelog entry with todays date and I can push it as 12.2 Done ! image

CrowdHailer commented 4 years ago

published. thanks :whale:

Leave a update on the forum if you fancy it. https://elixirforum.com/t/raxx-kit-micro-framework-for-web-applications/13805/19