CrowdStrike / ansible_collection_falcon

Comprehensive toolkit for streamlining your interactions with the CrowdStrike Falcon platform.
https://galaxy.ansible.com/ui/repo/published/crowdstrike/falcon/
GNU General Public License v3.0
97 stars 60 forks source link

Do not throw errors when running falcon_install and falcon_configure roles in Ansible check mode #431

Closed mikaaalto closed 6 months ago

mikaaalto commented 11 months ago

This PR adds better support for running falcon_install and falcon_configure roles in Ansible check mode.

Fixes errors like this when running in check mode:

fatal: [machine.xyz]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'path'. 'dict object' has no attribute 'path'\n\nThe error appears to be in '/home/user/.ansible/collections/ansible_collections/crowdstrike/falcon/roles/falcon_install/tasks/api.yml': line 73, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: CrowdStrike Falcon | Copy Sensor Installation Package to remote host (non-windows)\n  ^ here\n"}
carlosmmatos commented 10 months ago

I'll take a look at this soon

jwarnier commented 9 months ago

+1

carlosmmatos commented 6 months ago

Closing this as the current version will break idempotency and is not supported at the moment. I will open up an issue to look into supporting check mode for roles in future version.