search

CrowdStrike / ansible_collection_falcon

Comprehensive toolkit for streamlining your interactions with the CrowdStrike Falcon platform.
https://galaxy.ansible.com/ui/repo/published/crowdstrike/falcon/
GNU General Public License v3.0
97 stars 60 forks source link

Minor EDA test failures need resolution for next release #451

Closed alisonlhart closed 7 months ago

alisonlhart commented 8 months ago

There are some minor EDA linting failures on the 4.2.2 release (using our EDA test template, updated recently here).

Please resolve the following ruff failures in the next release:

extensions/eda/plugins/event_source/eventstream.py:1:1: D413 [*] Missing blank line after last section ("Examples")
extensions/eda/plugins/event_source/eventstream.py:70:5: D413 [*] Missing blank line after last section ("Methods")
extensions/eda/plugins/event_source/eventstream.py:106:9: D413 [*] Missing blank line after last section ("Parameters")
extensions/eda/plugins/event_source/eventstream.py:121:63: COM812 [*] Trailing comma missing
extensions/eda/plugins/event_source/eventstream.py:129:9: D413 [*] Missing blank line after last section ("Raises")
extensions/eda/plugins/event_source/eventstream.py:159:9: D413 [*] Missing blank line after last section ("Returns")
extensions/eda/plugins/event_source/eventstream.py:189:9: D413 [*] Missing blank line after last section ("Returns")
extensions/eda/plugins/event_source/eventstream.py:234:9: D413 [*] Missing blank line after last section ("Parameters")
extensions/eda/plugins/event_source/eventstream.py:267:9: D413 [*] Missing blank line after last section ("Returns")
extensions/eda/plugins/event_source/eventstream.py:299:9: D413 [*] Missing blank line after last section ("Returns")
extensions/eda/plugins/event_source/eventstream.py:341:9: D413 [*] Missing blank line after last section ("Raises")
extensions/eda/plugins/event_source/eventstream.py:390:9: D413 [*] Missing blank line after last section ("Returns")
extensions/eda/plugins/event_source/eventstream.py:412:5: D413 [*] Missing blank line after last section ("Raises")
extensions/eda/plugins/event_source/eventstream.py:465:9: PERF203 `try`-`except` within a loop incurs performance overhead
extensions/eda/plugins/event_source/eventstream.py:482:13: D413 [*] Missing blank line after last section ("Parameters")

Note: The 'blank line after ("Examples")' error will need to be two blank lines to fix the error, and the PERF203 error is up to your discretion whether to fix or add an in-line ignore.