search

CrowdStrike / ansible_collection_falcon

Comprehensive toolkit for streamlining your interactions with the CrowdStrike Falcon platform.
https://galaxy.ansible.com/ui/repo/published/crowdstrike/falcon/
GNU General Public License v3.0
97 stars 60 forks source link

fix(sensor_download): add file operation support to module #485

Closed carlosmmatos closed 6 months ago

carlosmmatos commented 6 months ago

Fixes #481

This PR introduces the built-in files AnsibleModule helper features to manage file operations such as mode, owner, group, etc.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 37.51%. Comparing base (a7c58af) to head (1a1eb9c). Report is 4 commits behind head on main.

Files Patch % Lines
plugins/modules/sensor_download.py 12.50% 7 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #485 +/- ## ========================================== - Coverage 37.75% 37.51% -0.24% ========================================== Files 17 17 Lines 837 845 +8 Branches 161 162 +1 ========================================== + Hits 316 317 +1 - Misses 520 527 +7 Partials 1 1 ``` | [Flag](https://app.codecov.io/gh/CrowdStrike/ansible_collection_falcon/pull/485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/CrowdStrike/ansible_collection_falcon/pull/485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `37.51% <12.50%> (-0.24%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dhoppe commented 6 months ago

@carlosmmatos I am glad that the module sensor_download is now able to change the owner, group and mode, but the role does not yet have the corresponding variables / defaults.

carlosmmatos commented 6 months ago

Dope 🤦🏻‍♂️. You're right, I was caught up in the process of updating the sensor module that I forgot that needs to be applied to the role. Apologies for that, I will have that out by end of day.

carlosmmatos commented 6 months ago

@dhoppe check out the latest PR #497