fix(falcon_configure): update logic for removing aid

carlosmmatos commented 5 months ago

Fixes #483

In this pull request, the following changes are made to provide backwards compatibility to existing removal of aid workflows:

Moved all the option checking logic to default variables stored as a dictionary. This restructuring simplifies the process of checking if any options have been set with jinja2.
Updated the existing configure task to utilize the new options dictionary.
Addressed a race condition where having a task immediately after restarting the sensor on a fresh install/configuration could occur. To mitigate this, a wait condition has been implemented until an AID is present.

With these changes, the pull request now accommodates two scenarios:

Added new molecule scenario to test the normal VM template/Gold Image workflow.

carlosmmatos commented 5 months ago

@redhatrises I don't know what's going on with the ansible-lint job. Seems to be some connectivity issue. It's working fine on my end.

dhoppe commented 5 months ago

@redhatrises I don't know what's going on with the ansible-lint job. Seems to be some connectivity issue. It's working fine on my end.

This might be related to the new Ansible Galaxy. It looks like the versions of the Ansible collection ansible.windows could not be fetched.

At least I saw a couple of issues where they received an HTTP 504. no idea what the return code 250 means.

CrowdStrike / ansible_collection_falcon