search

CrowdStrike / cloud-resource-estimator

Cloud deployment size calculation utilities
The Unlicense
17 stars 19 forks source link

Feature/azure container instances #44

Closed gtheodorio closed 1 month ago

gtheodorio commented 1 month ago

Resolves #42

yannhowe commented 1 month ago

Tiny thing, need to sync up the output path and command from the benchmark script and the cloud specific python

The output looks correct.

Also its weird to have this but can fix it up some other time. Threw me off while testing. https://github.com/gtheodorio/cloud-resource-estimator/blob/31deb3adf66840ae7a3cdb5f7188d6c09f59f9f9/benchmark.sh#L6

carlosmmatos commented 1 month ago

@yannhowe

Also its weird to have this but can fix it up some other time. Threw me off while testing. https://github.com/gtheodorio/cloud-resource-estimator/blob/31deb3adf66840ae7a3cdb5f7188d6c09f59f9f9/benchmark.sh#L6

The reason for this is because the wrapper script (benchmark.sh) is documented as being ran standalone (ie, not git clone). Because of this, we are using curl to download the cloud python script files to execute and this currently points to the main branch. I'm creating an issue soon on cleaning up/updating the wrapper script. I think it doesn't make sense to have it download everything into the virtual env directory, and this way we don't have to change the output to any of the python scripts as the end result should always be - the csv files are saved in the local directory (whether you run them manually or via the benchmark script).