CrowdStrike / cloud-resource-estimator

Cloud deployment size calculation utilities
The Unlicense
17 stars 19 forks source link

feat(gcp): updated + enhanced gcp estimation script #45

Closed carlosmmatos closed 1 month ago

carlosmmatos commented 1 month ago

Fixes #41

This PR introduces several improvements, enhancements, and bug fixes that were much needed. The main issue to target was to add the inclusion of tracking serverless resources in GCP. This PR adds

On top of that, I've added better logging support and error handling, especially around service APIs that are disabled in a project that is needed. This should also Fix #40 .

Other updates:

redhatrises commented 1 month ago

For GKE autopilot, are you able to add the node count since daemonset is recommended for deployment?

yannhowe commented 1 month ago

Looks like the output here

https://github.com/carlosmmatos/cloud-resource-estimator/blob/d914ea2ac89b20323f37657981cf6f0b1e1a37da/benchmark.sh#L158

needs to be synced up with the output from here

https://github.com/carlosmmatos/cloud-resource-estimator/blob/d914ea2ac89b20323f37657981cf6f0b1e1a37da/GCP/gcp_cspm_benchmark.py#L224

since most will run from root folder the paths won't be correct. Was the same with Azure

https://github.com/CrowdStrike/cloud-resource-estimator/pull/44#issuecomment-2255326775