update banner URL - Githubissues

CrowdStrike / community

CrowdStrike's Open Source Policy & Contribution Guide

https://opensource.crowdstrike.com

Apache License 2.0

35 stars 12 forks source link

update banner URL #31

Closed shawndwells closed 3 years ago

shawndwells commented 3 years ago

Just a hunch..... thinking the baseURL gets wonky since github adds a subdirectory to the domain.

eg the webpage is EXPECTING to be served as foo.com, however on github it deploys as foo.com/community/. This tests that theory. If the banner works then we need to alter these variables in the node_modules. Or just live with the banner not showing locally but working remotely.

shawndwells commented 3 years ago

BOFH merging to test. Will revert if breaks. Can only test by making the change live =/

shawndwells commented 3 years ago

yup this was it