search

CrowdStrike / csproto

CrowdStrike's Protocol Buffers library
MIT License
121 stars 13 forks source link

protoc-gen-fastmarshal doesn't support optional keyword of protobuf3 #130

Open rohsaini opened 8 months ago

rohsaini commented 8 months ago

message info { string name = 1; // POD name string addr = 2; // POD IP addr optional uint32 data = 3; }

xyz.proto: is a proto3 file that contains optional fields, but code generator protoc-gen-fastmarshal hasn't been updated to support optional fields in proto3. Please ask the owner of this code generator to support proto3 optional. --fastmarshal_out:

dylan-bourque commented 7 months ago

Apologies for the delayed response @rohsaini but I haven't had much time to allocate to OSS lately.

You are correct that we currently don't support proto3 optional fields. It could be added but it's not something that we (CrowdStrike) needed so it didn't make the cut.

I'd be happy to give input or review a PR if that's something you need.