CrowdStrike / ember-browser-services

Services for interacting with browser APIs so that you can have fine-grained control in tests.
MIT License
47 stars 12 forks source link

chore(deps): update testing dependencies (major) - autoclosed #386

Closed renovate[bot] closed 1 month ago

renovate[bot] commented 1 year ago

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
ember-qunit ^5.1.4 -> ^8.0.0 age adoption passing confidence
ember-try ^2.0.0 -> ^3.0.0 age adoption passing confidence
qunit-dom ^2.0.0 -> ^3.0.0 age adoption passing confidence

Release Notes

emberjs/ember-qunit (ember-qunit) ### [`v8.1.0`](https://togithub.com/emberjs/ember-qunit/releases/tag/v8.1.0): Release 8.1.0 [Compare Source](https://togithub.com/emberjs/ember-qunit/compare/v8.0.2...v8.1.0) ##### :rocket: Enhancement - [#​1166](https://togithub.com/emberjs/ember-qunit/pull/1166) feat: introduce `theme` config and add `qunit-theme-ember` as option ([@​IgnaceMaes](https://togithub.com/IgnaceMaes)) ##### Committers: 1 - Ignace Maes ([@​IgnaceMaes](https://togithub.com/IgnaceMaes)) ### [`v8.0.2`](https://togithub.com/emberjs/ember-qunit/releases/tag/v8.0.2): Release 8.0.2 [Compare Source](https://togithub.com/emberjs/ember-qunit/compare/v8.0.1...v8.0.2) ##### :bug: Bug Fix - [#​1140](https://togithub.com/emberjs/ember-qunit/pull/1140) Remove the "Disable linting" checkbox ([@​nelstrom](https://togithub.com/nelstrom)) - no supported version of ember-source / ember-cli has any overlap with the supported versions of libraries that utilized this capability - [#​1137](https://togithub.com/emberjs/ember-qunit/pull/1137) Add 'types' to package.json#exports because newer typescript versions ignore the package.json#types entry when package.json#exports is present ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) ##### Committers: 2 - Drew Neil ([@​nelstrom](https://togithub.com/nelstrom)) - [@​NullVoxPopuli](https://togithub.com/NullVoxPopuli) ### [`v8.0.1`](https://togithub.com/emberjs/ember-qunit/releases/tag/v8.0.1): Release 8.0.1 [Compare Source](https://togithub.com/emberjs/ember-qunit/compare/v8.0.0...v8.0.1) ##### :bug: Bug Fix - [#​1137](https://togithub.com/emberjs/ember-qunit/pull/1137) Add 'types' to package.json#exports because newer typescript versions ignore the package.json#types entry when package.json#exports is present ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) ##### Committers: 1 - [@​NullVoxPopuli](https://togithub.com/NullVoxPopuli) ### [`v8.0.0`](https://togithub.com/emberjs/ember-qunit/releases/tag/v8.0.0): Release 8.0.0 [Compare Source](https://togithub.com/emberjs/ember-qunit/compare/v7.0.0...v8.0.0) ##### :boom: Breaking Change - [#​1111](https://togithub.com/emberjs/ember-qunit/pull/1111) Requires ember-cli ~v4.8.1, ~v4.12.2, >= v5.1 ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) ##### :rocket: Enhancement - [#​1134](https://togithub.com/emberjs/ember-qunit/pull/1134) Update dependencies to latest version ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) - [#​1102](https://togithub.com/emberjs/ember-qunit/pull/1102) Make public `disableContainerStyles` configuration option ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) ##### :memo: Documentation - [#​1094](https://togithub.com/emberjs/ember-qunit/pull/1094) Readme updates ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) - [#​1087](https://togithub.com/emberjs/ember-qunit/pull/1087) Update README.md ([@​MelSumner](https://togithub.com/MelSumner)) ##### :house: Internal - [#​1135](https://togithub.com/emberjs/ember-qunit/pull/1135) Add CI publishing ([@​kategengler](https://togithub.com/kategengler)) - [#​1099](https://togithub.com/emberjs/ember-qunit/pull/1099) Add types directory in the publish output ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) - [#​1098](https://togithub.com/emberjs/ember-qunit/pull/1098) Strict mode deps ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) - [#​1096](https://togithub.com/emberjs/ember-qunit/pull/1096) Update .gitignore ([@​MelSumner](https://togithub.com/MelSumner)) - [#​1064](https://togithub.com/emberjs/ember-qunit/pull/1064) Convert to native package ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) - [#​1062](https://togithub.com/emberjs/ember-qunit/pull/1062) Extract test app ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) - [#​1063](https://togithub.com/emberjs/ember-qunit/pull/1063) Switch to pnpm ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) - [#​1060](https://togithub.com/emberjs/ember-qunit/pull/1060) V2 Addon conversion prep: convert to single-package monorepo. ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) - [#​1090](https://togithub.com/emberjs/ember-qunit/pull/1090) Add push-dist workflow ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) - [#​1089](https://togithub.com/emberjs/ember-qunit/pull/1089) Remove hasEmberVersion ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) ##### Committers: 2 - Katie Gengler ([@​kategengler](https://togithub.com/kategengler)) - [@​NullVoxPopuli](https://togithub.com/NullVoxPopuli) - Melanie Sumner ([@​MelSumner](https://togithub.com/MelSumner)) ### [`v7.0.0`](https://togithub.com/emberjs/ember-qunit/releases/tag/v7.0.0): Release 7.0.0 [Compare Source](https://togithub.com/emberjs/ember-qunit/compare/v6.2.0...v7.0.0) ##### :boom: Breaking Change - [#​1077](https://togithub.com/emberjs/ember-qunit/pull/1077) Upgrade ember-test-helpers and node ([@​MelSumner](https://togithub.com/MelSumner)) ##### :house: Internal - [#​1077](https://togithub.com/emberjs/ember-qunit/pull/1077) Upgrade ember-test-helpers and node ([@​MelSumner](https://togithub.com/MelSumner)) - [#​1028](https://togithub.com/emberjs/ember-qunit/pull/1028) Release 6.2.0 ([@​chriskrycho](https://togithub.com/chriskrycho)) ##### Committers: 2 - Chris Krycho ([@​chriskrycho](https://togithub.com/chriskrycho)) - Melanie Sumner ([@​MelSumner](https://togithub.com/MelSumner)) ### [`v6.2.0`](https://togithub.com/emberjs/ember-qunit/releases/tag/v6.2.0): Release 6.2.0 [Compare Source](https://togithub.com/emberjs/ember-qunit/compare/v6.1.1...v6.2.0) ##### :rocket: Enhancement - [#​1027](https://togithub.com/emberjs/ember-qunit/pull/1027) support Ember v5 ([@​jelhan](https://togithub.com/jelhan)) ##### :bug: Bug Fix - [#​1012](https://togithub.com/emberjs/ember-qunit/pull/1012) Add missing peer dependency on `@ember/test-helpers` ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) ##### :memo: Documentation - [#​1024](https://togithub.com/emberjs/ember-qunit/pull/1024) fix typo in docs ([@​laynegt](https://togithub.com/laynegt)) - [#​1001](https://togithub.com/emberjs/ember-qunit/pull/1001) Update migration docs for adopting native types in 6.1 ([@​dfreeman](https://togithub.com/dfreeman)) ##### :house: Internal - [#​1017](https://togithub.com/emberjs/ember-qunit/pull/1017) Migrate from htmlbars-inline-precompile to ember-cli-htmlbars ([@​gitKrystan](https://togithub.com/gitKrystan)) ##### Committers: 6 - Chris Krycho ([@​chriskrycho](https://togithub.com/chriskrycho)) - Dan Freeman ([@​dfreeman](https://togithub.com/dfreeman)) - Jeldrik Hanschke ([@​jelhan](https://togithub.com/jelhan)) - Krystan HuffMenne ([@​gitKrystan](https://togithub.com/gitKrystan)) - Layne Tcheng ([@​laynegt](https://togithub.com/laynegt)) - [@​NullVoxPopuli](https://togithub.com/NullVoxPopuli) ### [`v6.1.1`](https://togithub.com/emberjs/ember-qunit/releases/tag/v6.1.1): Release 6.1.1 [Compare Source](https://togithub.com/emberjs/ember-qunit/compare/v6.1.0...v6.1.1) ##### :bug: Bug Fix - [#​999](https://togithub.com/emberjs/ember-qunit/pull/999) Use native types from `ember-resolver` ([@​chriskrycho](https://togithub.com/chriskrycho)) - [#​998](https://togithub.com/emberjs/ember-qunit/pull/998) Revert explicit `peerDependencies` contracts ([@​chriskrycho](https://togithub.com/chriskrycho)) ##### Committers: 1 - Chris Krycho ([@​chriskrycho](https://togithub.com/chriskrycho)) ### [`v6.1.0`](https://togithub.com/emberjs/ember-qunit/releases/tag/v6.1.0) [Compare Source](https://togithub.com/emberjs/ember-qunit/compare/v6.0.0...v6.1.0) ##### :rocket: Enhancement - [#​995](https://togithub.com/emberjs/ember-qunit/pull/995) Feature: introduce native (ambient) TS types ([@​chriskrycho](https://togithub.com/chriskrycho)) ##### :house: Internal - [#​979](https://togithub.com/emberjs/ember-qunit/pull/979) Re-roll `yarn.lock` ([@​rwjblue](https://togithub.com/rwjblue)) - [#​978](https://togithub.com/emberjs/ember-qunit/pull/978) Update `lint` related scripts (add `lint:fix`) ([@​rwjblue](https://togithub.com/rwjblue)) - [#​977](https://togithub.com/emberjs/ember-qunit/pull/977) Ensure CI jobs timeout after 10 minutes ([@​rwjblue](https://togithub.com/rwjblue)) - [#​976](https://togithub.com/emberjs/ember-qunit/pull/976) Add Ember 4.8 to CI matrix ([@​rwjblue](https://togithub.com/rwjblue)) - [#​975](https://togithub.com/emberjs/ember-qunit/pull/975) Cancel prior CI jobs for same PR ([@​rwjblue](https://togithub.com/rwjblue)) - [#​973](https://togithub.com/emberjs/ember-qunit/pull/973) Bump github actions ([@​ctjhoa](https://togithub.com/ctjhoa)) ##### Committers: 4 - Camille TJHOA ([@​ctjhoa](https://togithub.com/ctjhoa)) - Chris Krycho ([@​chriskrycho](https://togithub.com/chriskrycho)) - Krystan HuffMenne ([@​gitKrystan](https://togithub.com/gitKrystan)) - Robert Jackson ([@​rwjblue](https://togithub.com/rwjblue)) ### [`v6.0.0`](https://togithub.com/emberjs/ember-qunit/releases/tag/v6.0.0): Release 6.0.0 [Compare Source](https://togithub.com/emberjs/ember-qunit/compare/v5.1.5...v6.0.0) ##### :boom: Breaking Change - [#​972](https://togithub.com/emberjs/ember-qunit/pull/972) Add support for Ember v4, drop support for < Ember 3.24 and deprecated features ([@​chriskrycho](https://togithub.com/chriskrycho)) - [#​921](https://togithub.com/emberjs/ember-qunit/pull/921) Update ember-auto-import to 2.x ([@​mydea](https://togithub.com/mydea)) - [#​931](https://togithub.com/emberjs/ember-qunit/pull/931) Drop support for Node < 14 ([@​mydea](https://togithub.com/mydea)) ##### :rocket: Enhancement - [#​972](https://togithub.com/emberjs/ember-qunit/pull/972) Add support for Ember v4, drop support for < Ember 3.24 and deprecated features ([@​chriskrycho](https://togithub.com/chriskrycho)) ##### :bug: Bug Fix - [#​912](https://togithub.com/emberjs/ember-qunit/pull/912) Make sure focus related tests don't fail when the test container is hidden ([@​bertdeblock](https://togithub.com/bertdeblock)) ##### :house: Internal - [#​914](https://togithub.com/emberjs/ember-qunit/pull/914) Fix CI ([@​bertdeblock](https://togithub.com/bertdeblock)) ##### Committers: 3 - Bert De Block ([@​bertdeblock](https://togithub.com/bertdeblock)) - Chris Krycho ([@​chriskrycho](https://togithub.com/chriskrycho)) - Francesco Novy ([@​mydea](https://togithub.com/mydea))
ember-cli/ember-try (ember-try) ### [`v3.0.0`](https://togithub.com/ember-cli/ember-try/blob/HEAD/CHANGELOG.md#v300-2023-08-16) [Compare Source](https://togithub.com/ember-cli/ember-try/compare/v2.0.0...v3.0.0) ##### :boom: Breaking Change - [#​920](https://togithub.com/ember-cli/ember-try/pull/920) Drop Node.js 14 support ([@​SergeAstapov](https://togithub.com/SergeAstapov)) ##### :rocket: Enhancement - [#​960](https://togithub.com/ember-cli/ember-try/pull/960) Use pnpm's --no-lockfile ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) - [#​956](https://togithub.com/ember-cli/ember-try/pull/956) Remove warning about pnpm ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) - [#​850](https://togithub.com/ember-cli/ember-try/pull/850) Add support for npm overrides ([@​mansona](https://togithub.com/mansona)) ##### :memo: Documentation - [#​957](https://togithub.com/ember-cli/ember-try/pull/957) Document pnpm options and behavior ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) ##### :house: Internal - [#​934](https://togithub.com/ember-cli/ember-try/pull/934) Update github CI yaml ([@​mansona](https://togithub.com/mansona)) - [#​933](https://togithub.com/ember-cli/ember-try/pull/933) Update smoke test to fix CI ([@​mansona](https://togithub.com/mansona)) - [#​893](https://togithub.com/ember-cli/ember-try/pull/893) update smoke-test-app to fix CI ([@​mansona](https://togithub.com/mansona)) ##### Committers: 3 - Chris Manson ([@​mansona](https://togithub.com/mansona)) - Sergey Astapov ([@​SergeAstapov](https://togithub.com/SergeAstapov)) - [@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)
mainmatter/qunit-dom (qunit-dom) ### [`v3.2.0`](https://togithub.com/mainmatter/qunit-dom/releases/tag/v3.2.0) [Compare Source](https://togithub.com/mainmatter/qunit-dom/compare/v3.1.2...v3.2.0) ##### :rocket: Enhancement - `qunit-dom`, `test-types-resolution-node`, `test-types-resolution-node16`, `test-types` - [#​2087](https://togithub.com/mainmatter/qunit-dom/pull/2087) feature: support IDOMElementDescriptors ([@​bendemboski](https://togithub.com/bendemboski)) ##### :house: Internal - `qunit-dom` - [#​2107](https://togithub.com/mainmatter/qunit-dom/pull/2107) Tighter null checks ([@​bendemboski](https://togithub.com/bendemboski)) ##### Committers: 1 - Ben Demboski ([@​bendemboski](https://togithub.com/bendemboski)) ### [`v3.1.2`](https://togithub.com/mainmatter/qunit-dom/releases/tag/v3.1.2) [Compare Source](https://togithub.com/mainmatter/qunit-dom/compare/v3.1.1...v3.1.2) ##### :bug: Bug Fix - `qunit-dom` - [#​2105](https://togithub.com/mainmatter/qunit-dom/pull/2105) fix(hasStyle): allow using camelCase properties inside assertion object ([@​BobrImperator](https://togithub.com/BobrImperator)) ##### Committers: 1 - Bartlomiej Dudzik ([@​BobrImperator](https://togithub.com/BobrImperator)) ### [`v3.1.1`](https://togithub.com/mainmatter/qunit-dom/releases/tag/v3.1.1) [Compare Source](https://togithub.com/mainmatter/qunit-dom/compare/v3.1.0...v3.1.1) ##### :bug: Bug Fix - `qunit-dom` - [#​2090](https://togithub.com/mainmatter/qunit-dom/pull/2090) Support ShadowRoot, add tests for rootElement, Closes [#​2089](https://togithub.com/mainmatter/qunit-dom/issues/2089) ([@​lolmaus](https://togithub.com/lolmaus)) ##### :house: Internal - `qunit-dom` - [#​2080](https://togithub.com/mainmatter/qunit-dom/pull/2080) remove hidden target override from compilerOptions ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) ##### Committers: 2 - Andrey Mikhaylov (lolmaus) ([@​lolmaus](https://togithub.com/lolmaus)) - [@​NullVoxPopuli](https://togithub.com/NullVoxPopuli) ### [`v3.1.0`](https://togithub.com/mainmatter/qunit-dom/releases/tag/v3.1.0) [Compare Source](https://togithub.com/mainmatter/qunit-dom/compare/v3.0.0...v3.1.0) ##### :rocket: Enhancement - `qunit-dom` - [#​1976](https://togithub.com/mainmatter/qunit-dom/pull/1976) Use getProperty for hasStyle assertions so testing can be done against css variables ([@​jkeen](https://togithub.com/jkeen)) ##### Committers: 2 - Bartlomiej Dudzik ([@​BobrImperator](https://togithub.com/BobrImperator)) - Jeff Keen ([@​jkeen](https://togithub.com/jkeen)) ### [`v3.0.0`](https://togithub.com/mainmatter/qunit-dom/releases/tag/v3.0.0) [Compare Source](https://togithub.com/mainmatter/qunit-dom/compare/v2.0.0...v3.0.0) ##### :boom: Breaking Change - [#​2031](https://togithub.com/mainmatter/qunit-dom/pull/2031) Drop ember qunit less than v6 ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) ##### :rocket: Enhancement - [#​2027](https://togithub.com/mainmatter/qunit-dom/pull/2027) Prepare for V2 Addon conversion. ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) - [#​1481](https://togithub.com/mainmatter/qunit-dom/pull/1481) Fix `hasAria()` docs and add `hasNoAria()` and `lacksAria()` aliases ([@​jamescdavis](https://togithub.com/jamescdavis)) ##### :memo: Documentation - [#​1348](https://togithub.com/mainmatter/qunit-dom/pull/1348) Update Build Status badge: Travis -> GH Actions ([@​SergeAstapov](https://togithub.com/SergeAstapov)) ##### :house: Internal - `qunit-dom` - [#​2066](https://togithub.com/mainmatter/qunit-dom/pull/2066) Switch to Vitest because it supports ESM ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) - [#​2055](https://togithub.com/mainmatter/qunit-dom/pull/2055) chore(release): copy static LICENSE and README into the package during build ([@​BobrImperator](https://togithub.com/BobrImperator)) - [#​1885](https://togithub.com/mainmatter/qunit-dom/pull/1885) chore(deps): update pnpm to v8 ([@​renovate\[bot\]](https://togithub.com/apps/renovate)) - `qunit-dom`, `test-app`, `test-vite-app` - [#​2054](https://togithub.com/mainmatter/qunit-dom/pull/2054) Move everything to the packages/ folder ([@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)) - Other - [#​2061](https://togithub.com/mainmatter/qunit-dom/pull/2061) chore(ci): use volta-cli github action for node and pnpm setup ([@​BobrImperator](https://togithub.com/BobrImperator)) - [#​1801](https://togithub.com/mainmatter/qunit-dom/pull/1801) Add eslint-plugin-jest ([@​bmish](https://togithub.com/bmish)) - [#​1696](https://togithub.com/mainmatter/qunit-dom/pull/1696) chore: downgrade documentation@13.2.5 to 13.2.4 ([@​BobrImperator](https://togithub.com/BobrImperator)) - [#​1600](https://togithub.com/mainmatter/qunit-dom/pull/1600) package.json: Specify `packageManager` field ([@​Turbo87](https://togithub.com/Turbo87)) - [#​1598](https://togithub.com/mainmatter/qunit-dom/pull/1598) tests: Remove `global` usage ([@​Turbo87](https://togithub.com/Turbo87)) - [#​1574](https://togithub.com/mainmatter/qunit-dom/pull/1574) Remove `.pnpm-debug.log` file ([@​Turbo87](https://togithub.com/Turbo87)) - [#​1573](https://togithub.com/mainmatter/qunit-dom/pull/1573) CI: Update Node.js versions ([@​Turbo87](https://togithub.com/Turbo87)) - [#​1572](https://togithub.com/mainmatter/qunit-dom/pull/1572) Remove `engines` declaration from `package.json` ([@​Turbo87](https://togithub.com/Turbo87)) - [#​1491](https://togithub.com/mainmatter/qunit-dom/pull/1491) Fix `documentation` integration ([@​Turbo87](https://togithub.com/Turbo87)) - [#​1434](https://togithub.com/mainmatter/qunit-dom/pull/1434) Revert "Update embroider monorepo to v0.50.2 (minor)" ([@​Turbo87](https://togithub.com/Turbo87)) - [#​1327](https://togithub.com/mainmatter/qunit-dom/pull/1327) Update dependency ember-source to v4 ([@​renovate\[bot\]](https://togithub.com/apps/renovate)) - [#​1365](https://togithub.com/mainmatter/qunit-dom/pull/1365) Ember.js: Declare `octane` edition compatibility ([@​Turbo87](https://togithub.com/Turbo87)) - [#​1361](https://togithub.com/mainmatter/qunit-dom/pull/1361) Use `pnpm` package manager ([@​Turbo87](https://togithub.com/Turbo87)) - [#​1360](https://togithub.com/mainmatter/qunit-dom/pull/1360) CI: Add Ember 3.28 scenario ([@​Turbo87](https://togithub.com/Turbo87)) - [#​1216](https://togithub.com/mainmatter/qunit-dom/pull/1216) CI: Fix `release` job ([@​Turbo87](https://togithub.com/Turbo87)) - [#​1217](https://togithub.com/mainmatter/qunit-dom/pull/1217) Remove duplicate `ember-cli-babel` dependency ([@​Turbo87](https://togithub.com/Turbo87)) ##### Committers: 6 - Bartlomiej Dudzik ([@​BobrImperator](https://togithub.com/BobrImperator)) - Bryan Mishkin ([@​bmish](https://togithub.com/bmish)) - James C. Davis ([@​jamescdavis](https://togithub.com/jamescdavis)) - Sergey Astapov ([@​SergeAstapov](https://togithub.com/SergeAstapov)) - Tobias Bieniek ([@​Turbo87](https://togithub.com/Turbo87)) - [@​NullVoxPopuli](https://togithub.com/NullVoxPopuli)

Configuration

šŸ“… Schedule: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined).

šŸš¦ Automerge: Enabled.

ā™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

šŸ‘» Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.



This PR was generated by Mend Renovate. View the repository job log.

changeset-bot[bot] commented 1 year ago

āš ļø No Changeset found

Latest commit: ac9ae9570c3ab1d32428c84805627172c94fc300

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR