search

CrowdStrike / ember-headless-table

https://ember-headless-table.pages.dev
MIT License
23 stars 7 forks source link

Support Ember v5 #150

Closed NullVoxPopuli closed 1 year ago

NullVoxPopuli commented 1 year ago

Noticed that the ember try scenarios for beta and canary were failing -- this should fix it

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 4df60e5c7295ba6ceb268ff67c0064137e1ff6f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

simonihmig commented 1 year ago

I wanted to say this is still failing due to an outdated version of ember-qunit, but then I saw there was https://github.com/CrowdStrike/ember-headless-table/pull/148 already (made by the same author 😜), which covers both changes. I guess we can merge that instead?

ynotdraw commented 1 year ago

@nicolechung and I went ahead and approved/merged https://github.com/CrowdStrike/ember-headless-table/pull/148 instead so closing this!