CrowdStrike / ember-headless-table

https://ember-headless-table.pages.dev
MIT License
23 stars 7 forks source link

Turbo and sync pnpm #168

Closed joelamb closed 1 year ago

joelamb commented 1 year ago

improve DX when building and running docs, tests and addon copied implementation of sync-pnpm from CrowdStrike/ember-headless-form#52

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 3e471a7227957a9f349760e3b854fb765ba3d7b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

NullVoxPopuli commented 1 year ago

For scenario testing typescript, you'll want an entry like this: https://github.com/NullVoxPopuli/ember-resources/blob/main/package.json#L55

joelamb commented 1 year ago

@NullVoxPopuli I tried adding the suggested allowAny but it didn't seem to help with typescript testing.

I wonder whether we need 4.5-4.7 in the ci.yml, given that ember-headless-form does have those typechecks

NullVoxPopuli commented 1 year ago

There is a bit too much going on in this PR, unrelated dependency updates, etc.

I'll throw up some PRs.

NullVoxPopuli commented 1 year ago

@joelamb starting with: https://github.com/CrowdStrike/ember-headless-table/pull/174

There is a plan laid out to get C.I. back to green.

github-actions[bot] commented 1 year ago

Preview URLs

GH Env: preview docs: https://362b67ce.ember-headless-table.pages.dev api docs: https://362b67ce.ember-headless-table.pages.dev/api/modules.html