search

CrowdStrike / ember-headless-table

https://ember-headless-table.pages.dev
MIT License
23 stars 8 forks source link

Drop support for TS <4.8, introduce TS support rolling-window-policy #176

Closed NullVoxPopuli closed 1 year ago

NullVoxPopuli commented 1 year ago

In order to officially support Glint, support for TS < 4.8 must be dropped as Glint only supports TS 4.8+.

Removing a TypeScript version from the support matrix is a breaking change, except when it falls out of the supported version range under the “rolling support windows” policy.

https://www.semver-ts.org/ In particular: https://www.semver-ts.org/#decouple-typescript-support-from-lts-cycles

So, this is a good time to adopt a TS rolling window support policy. Going from a min-version to rolling support window is a breaking change.

For the general maintenance / upkeep on this repo, the review / merge order is the following:

  1. https://github.com/CrowdStrike/ember-headless-table/pull/174
  2. https://github.com/CrowdStrike/ember-headless-table/pull/147
  3. https://github.com/CrowdStrike/ember-headless-table/pull/176
  4. https://github.com/CrowdStrike/ember-headless-table/pull/175
  5. https://github.com/CrowdStrike/ember-headless-table/pull/168

Each of these PRs, if rebased after the prior PR is merged, should go green.

Note, that, from forks, the publish to cloudflare will fail unless this publish strategy is adopted: https://github.com/NullVoxPopuli/limber/blob/main/.github/workflows/deploy-preview.yml

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: f3435c37d5aa95b9d6593c5f06142d85cb9fc6a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | ember-headless-table | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR