search

CrowdStrike / ember-headless-table

https://ember-headless-table.pages.dev
MIT License
23 stars 8 forks source link

[WIP] Reordering hidden columns #185

Open vitch opened 1 year ago

vitch commented 1 year ago

This PR addresses #152 by tweaking the way reordering is done...

From the commit message of the last commit:

In order to make the previously added test pass we need to give the column reordering plugin access to all columns, not just the visible ones. When moving left or right we need to iteratively swap the position of adjacent columns, continuing until we have swapped with a visible column. There are some failing tests for internals of the component on this commit but they can be fixed up later. I want to see if the new UX is desirable.

There is also some implementation tweaks I'd like to make (using a simple for loop would be more efficient because I could use the index in the array to do the swapping) but I can do that in a separate commit.

I'm also not sure if we could do away with or simplify the entire swapWith function (and maybe even orderOf?). There are some TODOs in the code as well for edge cases to clean up. At the moment I'm looking for verification that the approach seems sound and the generated UX is an improvement...

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 41811bb15a2787c8719d629cf7e3d19ecb97f933

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 1 year ago

Preview URLs

GH Env: preview docs: https://fb9a2780.ember-headless-table.pages.dev api docs: https://fb9a2780.ember-headless-table.pages.dev/api/modules.html

johanrd commented 3 months ago

@vitch hey, great work.

I'm curious: What did you end up doing here – are you using this functionality in a fork?

vitch commented 3 months ago

@vitch hey, great work.

I'm curious: What did you end up doing here – are you using this functionality in a fork?

I'm afraid I did the work because I needed it at work and I no longer work there... @joelamb might know if there is any active work on it?

NullVoxPopuli commented 3 months ago

Would there be interest in more distributed maintenance?

repo could be transferred to https://github.com/universal-ember/ ?