CrowdStrike / ember-headless-table

https://ember-headless-table.pages.dev
MIT License
23 stars 8 forks source link

fix: save table column order on setAll #200

Closed joelamb closed 1 year ago

joelamb commented 1 year ago

enable re-ordered columns to be saved to preferences

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: ced9ca399b7050149cdca78cfa0001a42b963509

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | ember-headless-table | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 year ago

Preview URLs

GH Env: preview docs: https://06fab8fb.ember-headless-table.pages.dev api docs: https://06fab8fb.ember-headless-table.pages.dev/api/modules.html

nicolechung commented 1 year ago

Suggestion: It would be helpful if we showed how this works with preferences in the docs:

The description of how to use it with preferences exists, but could stand to have a bit more detail (a demo or a code snippet of how to set it up)

Screenshot 2023-06-22 at 12 22 49 PM
joelamb commented 1 year ago

@nicolechung Code snippet added to documentation for Column Reordering. There is no setup required - the preferences object is automatically created when the plugin is included. It's up to the consuming app to handle where and how to save the provided object.

nicolechung commented 1 year ago

Code snippet added to documentation for Column Reordering. There is no setup required - the preferences object is automatically created when the plugin is included. It's up to the consuming app to handle where and how to save the provided object

I didn't fully read this the first time (osrry, Monday morning) and left a suggestion and then re-read your comment and deleted it. Pretty neat that the preferences object is automatically created!