CrowdStrike / ember-headless-table

https://ember-headless-table.pages.dev
MIT License
23 stars 8 forks source link

chore: flaky test fixes #222

Closed joelamb closed 1 year ago

joelamb commented 1 year ago

await requestAnimationFrameSettled() before checking column width values in the DOM

some resizing tests were a bit flaky not returning the expected column widths. eg. on resetting four columns in a 1000px container the test would sometimes return the col widths as 128px (the min) rather than the expected (250px - 1/4 of the overall container width). I suspect that this is due to the test checking before the full reset and new width calculation was complete and the table fully rendered and settled.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 1a751cd5550a680a551ed1dc2b1c7d150d2a6fbf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 1 year ago

Preview URLs

GH Env: preview docs: https://2988d77a.ember-headless-table.pages.dev api docs: https://2988d77a.ember-headless-table.pages.dev/api/modules.html