CrowdStrike / ember-headless-table

https://ember-headless-table.pages.dev
MIT License
23 stars 8 forks source link

fix: Resize plugin, add destroy check #226

Closed nicolechung closed 1 year ago

nicolechung commented 1 year ago

Similar to: https://github.com/CrowdStrike/ember-headless-table/blob/02b84b0069e621bfcf1b9439206c7043c9dd7dc0/ember-headless-table/src/plugins/column-resizing/resize-observer.ts#L38

The ResizeObserver checks to see if the table is destroyed, if it is, it does not create a new ResizeObserver.

This is missing in the plugin, which causes this error: Uncaught Error: You attempted to get the value of a helper after the helper was destroyed, which is not allowed

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 154acc4004b63c2b1a40031db85c26d0675e584e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | ember-headless-table | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 year ago

Preview URLs

GH Env: preview docs: https://11cc1483.ember-headless-table.pages.dev api docs: https://11cc1483.ember-headless-table.pages.dev/api/modules.html