CrowdStrike / ember-headless-table

https://ember-headless-table.pages.dev
MIT License
23 stars 8 forks source link

Save plugin preferences with expected static key #237

Open joelamb opened 9 months ago

joelamb commented 9 months ago

This BREAKING CHANGE fixes issue#238 by correctly using the name property of the plugin class to save preferences.

Updates tests

Why is this a breaking change? Because, any previously saved preferences will no longer work, since the keys they are currently using will not be recognised

changeset-bot[bot] commented 9 months ago

⚠️ No Changeset found

Latest commit: a11e22e80eb94af693258f406d2bc14f56afd448

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR