Update ember-resources from v5 to v7

Via

npx ember-resources-codemod

Here is the code for the codemod: https://github.com/NullVoxPopuli/ember-resources/pull/1147

There aren't many breaking changes from v5 to v7.

Here are the breaking changes in v6:

https://github.com/NullVoxPopuli/ember-resources/releases/tag/ember-resources%406.0.0
- Of note, the map utility (which this library uses) has changed its type signature for better inference)
- most of the changes here do not affect ember-headless-table because most of the changes are from utilities that ember-headless-table doesn't import/use (more on this in v7)

Here are the breaking changes in v7:

https://github.com/NullVoxPopuli/ember-resources/releases/tag/v7.0.0-ember-resources
- All utilities moved to reactiveweb, documentation here: https://reactive.nullvoxpopuli.com/
- This mostly doesn't affect ember-headless-table, because ember-headless-table is only using map
- Additionally, the Resource class has moved to a separate package, https://github.com/NullVoxPopuli/ember-modify-based-class-resource/
- This is to align with the ember ecosystem, and the desire to move away from modify() hooks -- as they are a sort of backdoor effect, which we don't want to encourage -- instead folks should rely on more data derivation patterns (ember-headless-table is, in general, a great example of data derivation)

Of note, because ember-resources has such broad support (3.28 - 6+), ember-resources declares a peer on ember-source so that it can correctly choose which features to use based on the consuming app's version.

As a result, ember-resources (in pnpm7 anyway), ember-resources must also become a peer, which is a breaking change. (However, I'm exploring if peers can be removed entirely here https://discord.com/channels/480462759797063690/568935504288940056/1281690947708784681 -- which would make this PR not a breaking change (once I propagate the findings to the relevant libraries))

There is a fair bit of this code:

import { dependencySatisfies, importSync, macroCondition } from '@embroider/macros';

let getOwner: (context: unknown) => Owner | undefined;
let setOwner: (context: unknown, owner: Owner) => void;

if (macroCondition(dependencySatisfies('ember-source', '>=4.12.0'))) {
  getOwner = importSync('@ember/owner').getOwner;
  setOwner = importSync('@ember/owner') .setOwner;
} else {
  getOwner = importSync('@ember/application').getOwner;
  setOwner = importSync('@ember/application').setOwner;
}

The default ember-source for ember-headless-table is v4, but it looks like 3.28+ is also supported (the same range as ember-resources).

Though, while addressing this, I ran in to a number of peer problems. It may be best to address those in separate PRs, but they are included here in hopes that CI goes green, since I hadn't yet contributed to this repo since my time at CS.

I also ran in to a number of maintenance problems that will probably not mean this PR will go green

out of date dependencies:
- @embroider/*
- ember-cli
- ember-auto-import
- pnpm

These alone are not problematic except when wanting to have fixed build problems. In particular, I noticed with the current repo's dependencies, the dependency graph is incorrect, and packages are being resolved incorrectly -- for example, something is trying to resolve reactiveweb/dist/index, but that file doesn't exist, and nor should it -- because you only pay for what you import, and having a barrel file for a generic library would be bad for performance.

So, I guess this PR is more demonstration than anything, as other work must happen before this work can attempt to go green.

(If I used this library, I'd PR fixes for ya'll -- but I haven't had a need for a table in a while -- my timebox ran out on trying to get this repo working <3 )

CrowdStrike / ember-headless-table

Update ember-resources from v5 to v7 #281

🦋 Changeset detected