search

CrowdStrike / ember-headless-table

https://ember-headless-table.pages.dev
MIT License
23 stars 7 forks source link

docs: updating contributing with a note about linking the dist folder #43

Closed nicolechung closed 2 years ago

nicolechung commented 2 years ago

What changed

Added a note about doing pnpm i after pnpm build

github-actions[bot] commented 2 years ago

Preview URLs

GH Env: preview docs: https://b7236ad3.ember-headless-table.pages.dev api docs: https://b7236ad3.ember-headless-table.pages.dev/api/modules.html

NullVoxPopuli commented 2 years ago

I added this note here: https://github.com/CrowdStrike/ember-headless-table/pull/12/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055

Is there anything you feel that is missing? 🤔

nicolechung commented 2 years ago

I added this note here: https://github.com/CrowdStrike/ember-headless-table/pull/12/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055

Is there anything you feel that is missing? 🤔

Good point, I read that and still forgot it. Going to close this