search

CrowdStrike / ember-headless-table

https://ember-headless-table.pages.dev
MIT License
23 stars 7 forks source link

sticky / pinnable columns demo uses the column header modifier on cells -- seems off #71

Open NullVoxPopuli opened 1 year ago

NullVoxPopuli commented 1 year ago

this is the code at the time of reporting:

 {{#each this.table.rows as |row|}}
        <tr class="relative">
          {{#each this.table.columns as |column|}}
            <td
              {{this.table.modifiers.columnHeader column}}
              class="{{if (this.isSticky column) 'bg-basement' 'bg-ground-floor'}}"
            >

using the columnHeader modifier seems wrong. In the mean time, I can do what I need to with the isSticky helper, but should there be a cell modifier for this situation?

NullVoxPopuli commented 1 year ago

semi resolved in #94 -- long term fix requires "cell modifiers" which, for performance, is blocked by emberjs/rfcs#883