CrowdStrike / ember-headless-table

https://ember-headless-table.pages.dev
MIT License
23 stars 7 forks source link

Protect against invalid column configs #81

Closed NullVoxPopuli closed 1 year ago

NullVoxPopuli commented 1 year ago

Prereq: https://github.com/CrowdStrike/ember-headless-table/pull/82, #83, #84 Resolves: https://github.com/CrowdStrike/ember-headless-table/issues/70

See changeset + test for details.

tl;dr: we can improve DX by failing as early as we can when accessing the column configs for the first time.

Without this, we'd get very hard to debug errors (especially around column re-ordering where the key of a column is very important)

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: c60e081118a46b62a85087e85a2e2614f7696f43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | ember-headless-table | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 year ago

Preview URLs

GH Env: preview docs: https://99b6830c.ember-headless-table.pages.dev api docs: https://99b6830c.ember-headless-table.pages.dev/api/modules.html