Closed NullVoxPopuli closed 6 months ago
Latest commit: 42069570b1236ed13759e8a5265f3d89954b5c29
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Looks like some type errors, but otherwise looks good to me!
. prepare: [!] (plugin Typescript) TS2345: Argument of type 'true | [options?: Partial<Options & Omit<Options, "boundary"> & { boundary: Boundary; }> | undefined]' is not assignable to parameter of type 'Partial<Options & Omit<Options, "boundary"> & { boundary: Boundary; }> | undefined'.
. prepare: Type 'true' has no properties in common with type 'Partial<Options & Omit<Options, "boundary"> & { boundary: Boundary; }>'.
. prepare: src/modifiers/velcro.ts (82:49)
. prepare:
. prepare: 82 (autoPlacementOptions ? autoPlacement(autoPlacementOptions) : flip(flipOptions)),
. prepare: ~~~~~~~~~~~~~~~~~~~~
. prepare:
. prepare: undefined
Let me know and I can add a changeset on top of this. A minor
I assume, eh?
Ye
I hadn't tried for Polish because i didn't know yet if ya'll wanted to feature yet 😅
Resolves: https://github.com/CrowdStrike/ember-velcro/issues/96
I think autoPlacement is better than flip, but folks should still have the option to choose, probably.