search

CrowdStrike / ember-velcro

Ember Velcro sticks one element to another with Floating UI.
MIT License
13 stars 8 forks source link

yield setHook function #186

Closed miguelcobain closed 7 months ago

miguelcobain commented 7 months ago

I faced a situation where I need to apply the hook modifier + some custom logic to the element. The problem is that modifiers aren't composable in ember. So we can't create a custom modifier that applies another modifier.

For that reason, in this PR I'm yielding a setHook function, thus increasing the composability options for users.

changeset-bot[bot] commented 7 months ago

🦋 Changeset detected

Latest commit: 6bdf51b75524971aef592641a3eb314d7d8a44a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------ | ----- | | ember-velcro | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ynotdraw commented 7 months ago

Thanks @miguelcobain! This is excellent.

miguelcobain commented 7 months ago

@ynotdraw I pushed a fix for the typecheck error CI was reporting. Please approve workflow. Thanks.