This PR implements several changes that aim to improve the system's handling of detection events and provide better debugging tools for these processes. Here are the key changes:
Refactoring of Event Type Checks: In backends/__init__.py, the way we check if RELEVANT_EVENT_TYPES is "ALL" has been modified. Instead of comparing the entire list to the string "ALL", we now check if "ALL" is an element of RELEVANT_EVENT_TYPES. This change allows for more flexibility in the RELEVANT_EVENT_TYPES configuration, as it does not have to be exactly "ALL" to be considered as such.
Minor Grammar Change: In falcon/models.py, the logging message for when a detection event is skipped has been grammatically fixed.
Incorporation of Relevant Event Types in Streaming Connection: Changes in falcon/stream.py add relevant_event_types as a parameter in the StreamingConnection class. This allows relevant_event_types to be used when establishing the connection. Now, when constructing the URL for the streaming connection, if relevant_event_types is not None, it is added as a filter in the URL query parameters (&eventType=). This change should help in reducing unnecessary network traffic by filtering out irrelevant events directly at the source.
Enhanced Debugging Information: Also in falcon/stream.py, a new debugging log has been added to print the complete URL used for the streaming connection. This addition should assist in debugging issues related to streaming connection setup.
These changes are expected to enhance the system's performance and make it easier to manage and debug.
This PR implements several changes that aim to improve the system's handling of detection events and provide better debugging tools for these processes. Here are the key changes:
Refactoring of Event Type Checks: In
backends/__init__.py, the way we check ifRELEVANT_EVENT_TYPESis"ALL"has been modified. Instead of comparing the entire list to the string"ALL", we now check if"ALL"is an element ofRELEVANT_EVENT_TYPES. This change allows for more flexibility in theRELEVANT_EVENT_TYPESconfiguration, as it does not have to be exactly"ALL"to be considered as such.Minor Grammar Change: In
falcon/models.py, the logging message for when a detection event is skipped has been grammatically fixed.Incorporation of Relevant Event Types in Streaming Connection: Changes in
falcon/stream.pyaddrelevant_event_typesas a parameter in theStreamingConnectionclass. This allowsrelevant_event_typesto be used when establishing the connection. Now, when constructing the URL for the streaming connection, ifrelevant_event_typesis not None, it is added as a filter in the URL query parameters (&eventType=). This change should help in reducing unnecessary network traffic by filtering out irrelevant events directly at the source.Enhanced Debugging Information: Also in
falcon/stream.py, a new debugging log has been added to print the complete URL used for the streaming connection. This addition should assist in debugging issues related to streaming connection setup.These changes are expected to enhance the system's performance and make it easier to manage and debug.