search

CrowdStrike / falcon-scripts

Scripts to streamline the deployment and use of the CrowdStrike Falcon sensor
The Unlicense
137 stars 81 forks source link

feat(container-sensor-pull): add ability to filter tags by platform #220

Closed carlosmmatos closed 9 months ago

carlosmmatos commented 9 months ago

Fixes #215

This PR add the ability to use the -p|--platform argument to filter the list of tags.

*update*

After chatting with some folks, I think it's best to keep the original json output because there is an existing workflow already established with tools such as jq that make it easier for consumers to get specific data.

The new changes keeps the original output in place, but provides the additional platform filtering.

falcon-pioupiou commented 9 months ago

I liked the json output as we can leverage all features of jq (so the original design), but since then I didn't get annoyed - I'm pinging other CSA to get some feedback on this - I don't see any issues on my side to change the format

carlosmmatos commented 9 months ago

That's actually what we are chatting about now. I don't want to break anything from the output perspective, just want to make sure what's requested in the script is what comes back