search

CrowdStrike / terraform-kubectl-falcon

Module to manage CrowdStrike Falcon Sensor and the Kubernetes Protection Agent on a Kubernetes cluster.
https://registry.terraform.io/modules/CrowdStrike/falcon/kubectl/latest
The Unlicense
7 stars 14 forks source link

Fix Broken Links #35

Closed justindhillon closed 9 months ago

justindhillon commented 9 months ago

There are multiple broken links in the documentation of this project. Here is what I have fixed:

https://github.com/CrowdStrike/falcon-operator/tree/main/docs/node --> https://github.com/CrowdStrike/falcon-operator/tree/main/docs/resources/node

https://github.com/CrowdStrike/falcon-operator/tree/main/docs/container --> https://github.com/CrowdStrike/falcon-operator/tree/main/docs/resources/container

I found this links using a tool I created called link-inspector. If you find this PR useful, give the repo a :star:

I have also applied to the Software Engineer Intern - Summer 2024 (Remote) position at your company. If you could put a word in for me, it would be greatly appreciated.

redhatrises commented 9 months ago

Thanks @justindhillon !

Do you mind squashing the commits to a single commit, update the commit message to provide more info than links, and add the following line to the commit message?

- Fixes #34
justindhillon commented 9 months ago

I thought it was brest practice to split up your changes into small commits, making it easier to revert your change. Never the less the commits have been squashed and the fixes have been implemented. Ready to merge.

redhatrises commented 9 months ago

I thought it was brest practice to split up your changes into small commits, making it easier to revert your change.

Correct... but these are incredibly small changes to begin with. Ack