Crowdedlight / Crows-Electronic-Warfare

Arma 3 Mod that enables electronic warfare features such as Radio/Drone jamming and spectrum signal tracking
https://crowdedlight.github.io/Crows-Electronic-Warfare/
Other
17 stars 6 forks source link

Zeus EMP module does not function correctly (prematurely fires with script errors) #36

Closed Guac0 closed 2 years ago

Guac0 commented 2 years ago

Mods: CBA_A3, Zeus Enhanced, TFAR Beta, Crows Electronic Warfare.

When you place the "Fire EMP" Module in Zeus, an EMP is fired immediately. The options dialog remains and you can customize the options before pressing "Ok" to fire an EMP in the intended manner. The EMP that fires when you open the dialog has several errors, see Line 784 in the RPT (817 and 829 are other occurrences of it since I opened the dialog additional times closer to the player object to test scope removal).

Firing it via the "ok" button the dialog seems to not produce any script errors, although I could've sworn there was an error about TFAR during an EMP last week but maybe that's an issue with my group's main modpack... However, I selected the "Remove scopes and electronics" option and my Nightstalker optic wasn't removed, so that might be bugging out as well.

logfileCrowsEmpErrorNoMods.zip

Guac0 commented 2 years ago

Here's the error that happened last weekend in our main modpack, but I can't replicate it now, and even if I could then it would be almost impossible to fix given that we run 57 mods and the error doesn't occur with only Electronic Warfare and dependencies + TFAR loaded. Plus, maybe update v1.3.2 fixed it. Feel free to ignore this error.

16:53:31 Error in expression <moveItemsArray = ["MineDetector"];

if (crowsEW_zeus_hasTFAR) then {
_removeItem>
16:53:31   Error position: <crowsEW_zeus_hasTFAR) then {
_removeItem>
16:53:31   Error Undefined variable in expression: crowsew_zeus_hastfar
16:53:31 File z\crowsEW\addons\emp\functions\fnc_unitRemoveItems.sqf..., line 140
Crowdedlight commented 2 years ago

Thanks for reporting. You are indeed right. I did a mistake and forgot to clean up a file. Apologies.

Should be fixed now and I have pushed the release.

The second error I could not reproduce and I think that was one thing that was fixed or at least changed in 1.3.3 so it should work correctly. Otherwise don't hesitate to make a new issue on it with details on how to reproduce :)