search

Crown-Commercial-Service / govuk-frontend-jinja

Tools to use the GOV.UK Design System with Python webapps that use Jinja2 and Flask 🐍
MIT License
9 stars 6 forks source link

Simplify attribute, value iterations #62

Closed domoscargin closed 3 years ago

domoscargin commented 3 years ago

We currently add a check if and when we encounter a for attribute, value in iteration.

This PR simplifies this a bit.

I've left the (foo|bar) structure to make it explicit what we've added. However, even in those cases we have not explicitly checked ALL uses of that change.

This may be good enough until we deprecate this repo - alternatively, we will have to create explicit test cases for each example of this pattern in govuk-frontend: https://github.com/alphagov/govuk-frontend/search?l=HTML%2BDjango&q=for+attribute%2C+value+in

This PR adds one of those specific tests - for summary list actions.