search

Crowndev / crown-core

Core of Crown blockchain platform. Contribution repository is available by this link: https://gitlab.crownplatform.com/crown/crown-core. Github repository is a mirror.
http://www.crownplatform.com
MIT License
26 stars 18 forks source link

a small comment issue #85

Open zhanzhenzhen opened 6 years ago

zhanzhenzhen commented 6 years ago

I found a small issue in this repo when improving POW check in my bitcore-lib-crown repo.

In line 120 of chainparams.cpp, 

bnProofOfWorkLimit = ~arith_uint256(0) >> 32;  // Crown starting difficulty is 1 / 2^12

This must be introduced by dash, because Dash code is:

https://github.com/Crowndev/crowncoin/blob/9c40441a7ba6dfaf19be5c987c219fc89cce539b/src/chainparams.cpp#L125

Because crown starting difficulty is 1, unlike Dash's 1/4096, so I think the comment should be:

bnProofOfWorkLimit = ~arith_uint256(0) >> 32;  // Crown starting difficulty is 1 / 2^0
zhanzhenzhen commented 6 years ago

Just sent a pull request.

defunctec commented 4 years ago

@walkjivefly Can this be closed?