Crowsinc / LiveVisionKit

LiveVisionKit brings the powers of computer vision and image processing to OBS Studio; implementing state of the art filters such as image enhancement and real-time video stabilization.
GNU General Public License v3.0
153 stars 14 forks source link

Unable to scale Video Stabilizer output. #1

Closed Crowsinc closed 2 years ago

Crowsinc commented 2 years ago

This issue is provided for example.


System/Software Setup

Issue Description When the FidelityFX Super Resolution 1.0 filter is created before the Video Stabilizer, the stabilization crop persists despite scaling the source to the base canvas size. It seems that the crop is being applied after scaling even though the Video Stabilizer, being a video filter, should run before the scaling effect filter.

Expected Behavior The source should scale up to the output resolution set in the FidelityFX Super Resolution 1.0 filter. That is, the crop should be applied before scaling.

Reproduction Steps

  1. Create a VLC Video Source and load a video into it.
  2. Create a FidelityFX Super Resolution 1.0 filter that scales to canvas size.
  3. Create a Video Stabilizer filter with test mode off.

Supporting Evidence N/A

Appendix I have looked through the code and noticed that the Video Stabilizer is both a video and effects filter. Could this be the issue?

Crowsinc commented 2 years ago

This was meant to be a long term example issue, but it was solved in v1.0.1