search

Crozzers / screen_brightness_control

A Python tool for controlling the brightness of your monitor
https://crozzers.github.io/screen_brightness_control
MIT License
50 stars 9 forks source link

fixed wrong info type returned by sbc.windows.get_display_info() #12

Closed patwadeepak closed 3 years ago

patwadeepak commented 3 years ago

The issue has been fixed by putting a check before returning info from sbc.windows.get_display_info().

The check placed is a very simple if statement that checks if every item in info list is a dictionary.

Crozzers commented 3 years ago

One thing that I missed earlier, could you put the list comprehension before the call to __cache__.store?

Otherwise, the data will be cached before being verified and the next time get_display_info is called it will return the non-verified cached data.

Other than that this looks all good. Thank you

Crozzers commented 3 years ago

Changes have been merged and the __cache__.store call was moved. New version will be published shortly