search

CrshOverride / ember-web-api

Ember Data Addon for .NET Web API Endpoints
MIT License
20 stars 12 forks source link

Errors stopped working for newer Ember-Data > 2.x #7

Closed danshapir closed 8 years ago

danshapir commented 8 years ago 
Uncaught Error: Assertion Failed: `InvalidError` expects json-api formatted errors array.

Since you've changed what I've done and you return a plain JSON or errors, ember that has moved to JSON-API won't work.

parseErrorResponse is where it happens.

CrshOverride commented 8 years ago

@danshapir - I'll make the necessary changes. The last changes I made were to support Ember Data 1.13.15 as a JSON API formatted errors array actually failed in that version. I should be able to push tonight and release a 2.* compatible version.

CrshOverride commented 8 years ago

@danshapir I have a pending PR to address the issue. If at all possible, try installing from the branch and see if:

  1. The errors issue is resolved.
  2. Nothing else is broken in your application.

I plan on doing the same tomorrow myself.

danshapir commented 8 years ago

Good job! I'll try and check it tonight (other time-zone here :) )

CrshOverride commented 8 years ago

@danshapir I was able to verify on my own and it looks like errors worked properly and my relationships still loaded as expected. I'm closing this one out for now.

danshapir commented 8 years ago

OK great! Didn't get to it...