CruGlobal / conf-registration-web

Event Registration Tool
https://www.eventregistrationtool.com
MIT License
2 stars 1 forks source link

Breadcrumbs don't display correctly #31

Closed ryancarlson closed 10 years ago

ryancarlson commented 11 years ago

In app/views/registration.html, the check to see if there is an object validPages[pageId] fails and some breadcrumbs that should be active as links are not.

To replicate remove the validPages condition from both lines below in and the breadcrumbs work as expected:

<a href="#/register/{{conference.id}}/page/{{page.id}}" ng-show="page.id != activePageId">{{page.title}}</a>
<span ng-hide="page.id != activePageId">{{page.title}}</span>
robbyronk commented 11 years ago

I'm not sure I follow. The breadcrumbs were designed to only be links for pages that you've been to. The way it's implemented now is flawed. If a page has no required blocks, the page will be considered valid and will appear as a link.

:bug: