search

CruGlobal / conf-registration-web

Event Registration Tool
https://www.eventregistrationtool.com
MIT License
2 stars 1 forks source link

EVENT-776-Display-Foreign-Addresses #779

Closed TheNoodleMoose closed 2 years ago

TheNoodleMoose commented 2 years ago

This PR adds a new country input field for the event address and address question. For simplicity's sake, we made it to where if the country is non-US, the state select input just becomes a text input and the placeholders change to 'State/Region' and 'ZIP/Postal Code'. We do have to account that not every foreign address will have a state/region or even a zip, so we provide verbiage via a tooltip to let the user know they only need to fill in the applicable fields. Also if an address question is required, we don't want to require the state or zip part just in case it does not apply to them.

wrandall22 commented 2 years ago

One initial thought I have is that Siebel and give site use address line 1, 2, 3, 4 for international addresses. Not sure if we want to be consistent, maybe it's not worth it.

TheNoodleMoose commented 2 years ago

@wrandall22 So essentially city, state, and zip become generic address fields(Address Line 1, Address Line 2, etc) that are text inputs? I do kind of like that idea. @hlbraddock do you have opinions on this? I could also bring this idea up to Charles and Mike to see what they think.

wrandall22 commented 2 years ago

City, State, Zip becomes address lines 3 and 4. Totally different fields tracked on the backend.

hlbraddock commented 2 years ago

@wrandall22 So essentially city, state, and zip become generic address fields(Address Line 1, Address Line 2, etc) that are text inputs? I do kind of like that idea. @hlbraddock do you have opinions on this? I could also bring this idea up to Charles and Mike to see what they think.

We captured initial address requirements in https://jira.cru.org/browse/EVENT-776. If you have other ideas, we may want to confer with Product/Stakeholder once more.

TheNoodleMoose commented 2 years ago

@wrandall22 This is approved and on staging, just waiting to hear back from QA.

wrandall22 commented 2 years ago

@Benjamin-deVries please let me know when QA for this is done and we want to deploy.

Benjamin-deVries commented 2 years ago

@Benjamin-deVries please let me know when QA for this is done and we want to deploy.

@wrandall22 I believe QA is being taken care of by the Charles, i think. API is working and was already deployed end of Jan. Our only remaining involvement in this was troubleshooting if UI was getting errors.