search

CruGlobal / conf-registration-web

Event Registration Tool
https://www.eventregistrationtool.com
MIT License
2 stars 1 forks source link

EVENT-778-Provide-Filtering-On-Registrations-Export #782

Closed TheNoodleMoose closed 2 years ago

TheNoodleMoose commented 2 years ago

Ticket: https://jira.cru.org/browse/EVENT-778

The main purpose of the ticket was to add a new checkbox in the advanced options menu to apply current registration filters to the registration export. But I saw the opportunity to convert to react, so I went ahead and did that too 🙂

wrandall22 commented 2 years ago

Git history may have been nicer if it was 2 commits: 1 to add the checkbox, and 1 to convert to React (not necessarily in that order).

TheNoodleMoose commented 2 years ago

@wrandall22 That's a great point. @aaronlaib This is an example where although what I did in the commit connects with the work needed to be done, splitting it into two commits would help with clarity. I'll go about splitting this(1st commit converting to react; 2nd commit adding relevant checkbox).

TheNoodleMoose commented 2 years ago

@wrandall22 Went ahead and split the commits, thanks for the suggestion! This will need to wait to go to staging/production until the related API work is live.

TheNoodleMoose commented 2 years ago

@wrandall22 Scotty had approved this before, it just needs reapproval.