search

CruGlobal / conf-registration-web

Event Registration Tool
https://www.eventregistrationtool.com
MIT License
2 stars 1 forks source link

EVENT-791-Update-Merchant-Account-Information-Text #793

Closed TheNoodleMoose closed 2 years ago

wrandall22 commented 2 years ago

Did this wording come from somewhere or did you have to make it up yourself?

TheNoodleMoose commented 2 years ago

@wrandall22 I was provided it in https://jira.cru.org/browse/EVENT-791

wrandall22 commented 2 years ago

I am a bit curious why it is 3 translate tags instead of 1.

wrandall22 commented 2 years ago

Also, how would you go about putting the bold and italics in there? Or are they not required?

TheNoodleMoose commented 2 years ago

@wrandall22 It's actually funny you say that. I originally pushed it with one translate tag, but then realized it had been three before and maybe it should stay that way. I went ahead and separated it and then rebased and squashed. I'm not exactly sure the context or reasoning behind it being three different translates.

TheNoodleMoose commented 2 years ago

I don't know how the bolding or italics would work. Not sure if that would conflict with the translating logic to wrap it in <b> or <em>.

wrandall22 commented 2 years ago

One possibility for italics and bold, is, if they are required, you could break up the text more into other translate tags per style. Something like:

  <span if-block>
    <em><translate>Italic translated text</translate></em>
    <translate>Regular text</translate>
    <strong><translate>Bold text</translate></strong>
    <translate>Regular text</translate>
  </span>