CruGlobal / conf-registration-web

Event Registration Tool
https://www.eventregistrationtool.com
MIT License
2 stars 1 forks source link

Debounce option changes #823

Closed canac closed 1 year ago

canac commented 1 year ago

For some reason, ng-model-options="{ debounce: 1000 }" doesn't play nicely with radio buttons. If you click one option then a different one within one second, the selection is cleared when the debounce finally updates the value, even though the modal value is still set. Someone had a similar issue here with no resolution besides using a different method for debouncing.

Work around this issue by manually performing the debouncing within the controller.

wrandall22 commented 1 year ago

I wonder if the debounce was only there for the Other option. Is it still worth having with the refactoring that was done?

canac commented 1 year ago

@wrandall22 All other input types have ng-model-options="{ debounce: 1000 }" on the inputs. I'm not sure what the reasoning for the debouncing is, but keeping the debouncing for the radio buttons keeps it consistent with the other input types.