CruGlobal / conf-registration-web

Event Registration Tool
https://www.eventregistrationtool.com
MIT License
2 stars 1 forks source link

EVENT-825 Campus Question Force Selection Option #837

Closed caleballdrin closed 1 year ago

caleballdrin commented 1 year ago

Description

https://jira.cru.org/browse/EVENT-825

With the Salesforce integration we need to encourage the use of the Cru Profile questions to ensure better data and ensure our constituents are known by Cru. The Current "Campus" default question pulls from a database of Campuses but does require the registrant to select anything on the drop down list. This leads to inconsistent data as the same school could be represented in many ways with unlimited free form response.

The proposed improvement is as follows:

Update the default name when the question is used: "Campus- Type the full name of your campus and choose from the list that appears”

Changes I made

Companion PR https://github.com/CruGlobal/ert-api/pull/1030

dr-bizz commented 1 year ago

In the description, it mentions adding an additional checkbox Option on the admin panel that would “Force Selection from Cru Database”. I can't see that in this PR.

dr-bizz commented 1 year ago

It's worth making the campus dropdown have a max-height so prevent the from having to scroll down the page to see all the options when it returns lots.

caleballdrin commented 1 year ago

I was looking into setting max-height and came across this issue. Maybe we should just limit the results to 10 from the API. https://github.com/ng-bootstrap/ng-bootstrap/issues/1119

dr-bizz commented 1 year ago

Seems like there is a way but you have to make it work - https://github.com/ng-bootstrap/ng-bootstrap/issues/1119#issuecomment-504557094. It's bad management of the package owners that they haven't added this as a feature already. Unless it's no longer supported.