search

CruGlobal / cru_lib

MIT License
1 stars 0 forks source link

Fix push_structure_to_global_registry #3

Open knutsenm opened 8 years ago

knutsenm commented 8 years ago

I happened to notice that since November, Infobase has been unsuccessfully trying to POST /entity_types to GR with the parameters:

{"entity_type"=>{"name"=>"inst_id", ... "field_type"=>nil}}

because ministry_targetarea gained a bunch of new columns including inst_id.

I think this will fix the field_type=>nil for all clients.

twinge commented 8 years ago

Assuming you tested this (you should probably also check SMT before merging): :+1:

knutsenm commented 8 years ago

a) How do I test this? I don't know how when sidekiq is involved. b) By "check SMT" do you mean see what it's currently trying to do? I did an audit in splunk, and only Infobase is experiencing this problem. c) I think I'm supposed to bump the version number here, so I'm going to submit a patch for that first.

knutsenm commented 8 years ago

I've tested this locally, and Infobase properly posts new entity types to global_registry.

Infobase doesn't like the current version of cru_lib, however; it needs to have its active_model_serializers upgraded.