CrucibleMC / Crucible

Crucible, a fork of Thermos, is a CraftBukkit and Forge server implementation for 1.7.10, providing the ability to load both Forge mods and Bukkit plugins alongside each other.
https://discord.gg/jWSTJ4d
GNU General Public License v3.0
184 stars 63 forks source link

[BUG] Memoty leak: entities not cleaned if you generate map with WorldBorder plugin without players #167

Open gravit0 opened 1 week ago

gravit0 commented 1 week ago

Describe the bug Map generation with WorldBorder causes memory leaks due to large number of entities and tile entities that are never cleared because the server does not tick when there are no players.

To Reproduce

  1. Install WorldBorder plugin
  2. Start map generation without players
  3. Generation stopped because memory is low

Expected behavior It might be worth clearing entities in the absence of players elsewhere

Logs

Screenshots Screenshot_20241022_053209

Additional context Method updateEntities() in World executed only in tick()

Environment (please complete the following information):

EverNife commented 1 day ago

Well, now that you mention that, this is really a bug that i have faced like forever on Thermos/Crucible.

My main problem with this bug is related with items. Sometimes like thousands of items are spawned on specific chunks and the amount just increase until a players come closer to the the chunk and them all of the items are removed at once.

I think this is indeed a serious problem, not only for when generating chunks, but for chunkloaders as well.