search

CrucibleMC / Crucible

Crucible, a fork of Thermos, is a CraftBukkit and Forge server implementation for 1.7.10, providing the ability to load both Forge mods and Bukkit plugins alongside each other.
https://discord.gg/jWSTJ4d
GNU General Public License v3.0
184 stars 63 forks source link

JsonToNBT|MojangsonParser does not load NBT from String Properly #56

Closed EverNife closed 3 years ago

EverNife commented 3 years ago

When an NBT with Empty fields is inserted, the empty fields turn into ""

For example:

Item A has the folowing LORE image And its NBT data is:

.withTag({display: {Lore: ["a", "", "", "b"]}}) When trying to give an item using `minecraft:give customnpcs:npcWand 1 0 {display: {Lore: ["a","","","b"]}}` this is the result ![image](https://user-images.githubusercontent.com/11357801/108438515-292fe980-722e-11eb-92f9-72510477c7dd.png)
EverNife commented 3 years ago

This bug is present on Crucible, Mohist and Thermos.

Seems to be a really old bug :/

EverNife commented 3 years ago

Ok, this is a Forge Bug, even on clien-side this happens when using:

String nbtTag = itemStack.getTagCompound().toString();

image

The NBT.toString() is entirely broken