search

CrucibleMC / Crucible

Crucible, a fork of Thermos, is a CraftBukkit and Forge server implementation for 1.7.10, providing the ability to load both Forge mods and Bukkit plugins alongside each other.
https://discord.gg/jWSTJ4d
GNU General Public License v3.0
184 stars 63 forks source link

MobiusCore Incompatibility (wrong references to internal hashed array list) #59

Closed Skyere closed 8 months ago

GedeonGrays commented 3 years ago

I confirm the problem. Previously, MobiusCore-Thermos still worked, but now even it is incompatible with Crucible. Tested with Crucible-1.7.10-4.1-dev-a1b8362-server (version from the dev-branch of TeamCity for some reason 4.1, not 5.0+).

mjra007 commented 3 years ago

Tested with Crucible 5.0 and also couldnt get it to work.

juanmuscaria commented 3 years ago

It uses a hardcoded reference for the hashed arraylist, which was changed and then removed from crucible in favor to a better implementation. We will need an updated for that mod

GedeonGrays commented 3 years ago

We will need an updated for that mod

That is, you will do as Thermos did by releasing their version of MobiusCore. Okay, we'll wait. Thanks for your quick response :3

sanik commented 3 years ago

It uses a hardcoded reference for the hashed arraylist, which was changed and then removed from crucible in favor to a better implementation. We will need an updated for that mod

Can you make a patch or custom version of the mod that will work?

Fox2Code commented 2 years ago

Well probably the best solution is to create an thermos.chaud.HashedArrayList empty class that extend the "better implementation", IMO this is the easiest way to fix this issue.

EverNife commented 2 years ago

Well probably the best solution is to create an thermos.chaud.HashedArrayList empty class that extend the "better implementation", IMO this is the easiest way to fix this issue.

Seems simple enought :D

spannerman79 commented 2 years ago

That is, you will do as Thermos did by releasing their version of MobiusCore. Okay, we'll wait. Thanks for your quick response :3

Not quite.

The fix originally was done at my request (cannot provide issue link as the original repo of the person that made the fix is no longer public/removed - author was https://github.com/RoyCurtis ) for KCauldron. The fix that Thermos had was the exact same release as the KCauldron one - just forked from the now non existant repo.

AlexCatze commented 1 year ago

Fixed version of opis: https://github.com/AlexCatze/Opis/tree/crucible-support

juanmuscaria commented 8 months ago

Closing as solved