CrucibleMC / Grimoire-legacy

General-purpose Mixin loader framework, which allows to properly implement mixins on 1.7.10/1.12.2 versions of Minecraft. For updated version check out https://github.com/Aizistral-Studios/Grimoire
GNU General Public License v3.0
23 stars 6 forks source link

Grimoire folder is not being generated #18

Closed joaoespanhol closed 3 years ago

joaoespanhol commented 3 years ago

I have installed grimoire on the mods folder, but there is no grimoire folder for me to install the mixins

version 1.7.1.0

drori200 commented 3 years ago

You need to add the mixins to the mods folder afaik

Aizistral commented 3 years ago

Don't see any bugs here, @evernife. I thought we all agreed we don't need to make a legacy support for feature that was already legacy in legacy version of Grimoire

EverNife commented 3 years ago

Do not generate the folder grimoire when legacy is enabled is the bug.

But, besides that, I am still on grimoire v1

I am reading thought all modifications thought the versions, after that i will do some changes and than maybe i will upgrade all my mixins to the new version.

joaoespanhol commented 3 years ago

Don't see any bugs here, @evernife. I thought we all agreed we don't need to make a legacy support for feature that was already legacy in legacy version of Grimoire

in version 1.7.1.0 it is not generating the grimoire folder to put mixis-mods

Aizistral commented 3 years ago

That folder was removed in v2 guys. You just use mods folder for the purpose it had

spannerman79 commented 3 years ago

... and why https://github.com/CrucibleMC/Grimoire/wiki should be used/updated.

Shouldn't have to crawl through commit messages or know the codebase offhand to know.

Aizistral commented 3 years ago

... and why https://github.com/CrucibleMC/Grimoire/wiki should be used/updated.

Shouldn't have to crawl through commit messages or know the codebase offhand to know.

Juan once said he'll be working on wiki. Some 4 months ago

EverNife commented 3 years ago

That folder was removed in v2 guys. You just use mods folder for the purpose it had

So, if there are 20 mixins modules (each one in each jar) you just throw all of them in the mods folder?

image

Aizistral commented 3 years ago

So, if there are 20 mixins modules (each one in each jar) you just throw all of them in the mods folder?

I dunno, probably? Honestly that's why I would've preffered there to be a single mod with config to disable or enable individual modules

EverNife commented 3 years ago

Sure, to be honest i don't have time to nor the wish to discuss something that is so meaningless.

"Generate a folder called grimoire for just a better organization"

After juan finishes his coremod transcription i may apply the remaining mixins. His coremod will be into a single jar so might not even need the folder anymore.

After that we will even be able to just drop support for legacy mixins.