Elements review

[rob101]

Design considerations

• The current schema design for elements has a large number of fields which could lead to a wide table, especially if the number of instances is high.
• You may want to consider splitting this model into several smaller models or use a different database structure, like JSON fields, as we have done with DynamicForms

Separation of concerns

• Element seems to be managing both data and presentation logic, merging model and view concerns?
• It's likely this will break SOLID design, which I'd try to adhere to if you can. It will make life easier!

[tomtitherington]

Thanks for taking a look through the repo Rob, really appreciate it. I should have explained though, the current schema is completely outdated and doesn't reflect this new direction of "engagement flows"... sorry!

What we have now is essentially a finite state machine, I'll have a look through those repos you linked.

The large number of fields is due to how I model inheritance between the model classes. Separating into multiple tables would have led to multiple joins on each table, which I thought would have been costly.