Crunch-io / rcrunch

R package for interacting with the Crunch API
https://crunch.io/r/crunch/
GNU Lesser General Public License v3.0
9 stars 15 forks source link

Add a bit more user validation for `makeWeightVariable` #184

Open jonkeane opened 6 years ago

jonkeane commented 6 years ago

If a user tries to send a known-malformed set of weights we should try and warn gently.

For instance: if a category that has 0 observations is given a weight, raking will never converge.

persephonet commented 6 years ago

On the note of improvements to makeWeight, I think missing categories should not need to be included in the targets even if the missing category is in the middle of the non-missing categories.